This repository was archived by the owner on Jun 29, 2020. It is now read-only.
Refactor unregister address method #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 478
💛 - Coveralls |
|
I think we should add conditional for clarity. |
|
Done. I also fixed the issue with the coverage script. |
Closed
phahulin
reviewed
May 30, 2018
| @@ -342,11 +342,9 @@ contract ProofOfPhysicalAddress { | |||
| // Remove physical address from list | |||
| uint256 length = users[msg.sender].physicalAddresses.length; | |||
|
|
|||
| for (uint256 i = index; i < length - 1; i++) { | |||
| users[msg.sender].physicalAddresses[i] = users[msg.sender].physicalAddresses[i+1]; | |||
| if (length > 1) { | |||
There was a problem hiding this comment.
Shouldn't this be if (index != length -1) { ?
There was a problem hiding this comment.
Oh, that's much better. Thanks.
phahulin
approved these changes
May 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
Closes #155.
Note that this will do an unnecessary assignment when the user removes the last address, but I'm not sure if adding a conditional is worth it.
I also added more tests to be sure that it's working as expected.