[FIX] #3569 Fixed fetching Azure AD User with apostrophe in UPN #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danielcecil for your contribution! I have moved this fix to a lower level so two other cmdlets which ran into the same issue can also benefit from it. |
|
Nice work! Thanks for looking a bit deeper 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes (#3569)
What is in this Pull Request ?
Added a String.Replace function to the Identity parameter on GetAzureADUser.cs to replace single apostrophe's with doubles. e.g.
John.O'[email protected]becomesJohn.O''[email protected]as a result.This ensures the apostrophes are correctly escapes. Note that UrlEncode does not achieve this fix.