Super basic simple fix: now accepts -RowLimit parameter #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Partial fix to #2485.
What is in this Pull Request ?
The commandlet now accepts RowLimit parameter (earlier it was always ignored due to how Identity was managed, and the commandlet could effectively be used to only restore 1 item at a time). This implementation blindly accepts the -RowLimit (without validating whether the number makes sense).
A proper fix should also implement paging or at least verify that restoring with high RowLimits works (which I can also test myself later on if need be).
Also adds a nicer message for confirming restoring X number of items.