Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filter parameter to Get-PnPTeamsTeam #2467

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

koskila
Copy link
Contributor

@koskila koskila commented Oct 14, 2022

I had a moment to go through the open issues, and figured I'd offer this basic implementation to #1301.

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Partially implements #1301

This doesn't implement Advanced queries yet (https://learn.microsoft.com/en-us/graph/aad-advanced-queries), but if #2466 is merged, I could easily implement that for this commandlet as well.

What is in this Pull Request ?

  • Implement "Filter" parameter for Get-PnPTeamsTeam

@gautamdsheth
Copy link
Collaborator

Awesome stuff @koskila, much appreciated :)

Can you also please update the docs as well?
You need to modify the Get-PnPTeamsTeam.md file inside the documentation folder.
Adding a parameter would be enough.
Adding an additional example showing the usage of this Filter will be awesome to have 😊🙏

@koskila
Copy link
Contributor Author

koskila commented Oct 15, 2022

Ohhh, how silly of me - I have used the documentation myself, but had no idea where it came from. Will do 😅

@gautamdsheth
Copy link
Collaborator

No worries, all good here 😊

Thank you @koskila for adding this, have merged it. Will be available in tomorrow's nightly as well as the next major version whenever we release it.
Really glad to have to you contributing here, much appreciated 😊🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants