Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances Set-PnPContentType to allow configuring Form Customizers. Closes #2451 #2456

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

martinlingstuyl
Copy link
Contributor

Closes #2451

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

#2451

What is in this Pull Request ?

Enhances Set-PnPContentType to allow configuring Form Customizers.

@gautamdsheth
Copy link
Collaborator

hi @martinlingstuyl, great stuff!

Can you also please update the docs as well related to this cmdlet?
You need to update the Set-PnPContentType.md file which is in the documentation folder?
Let me know if you need more info from me :)

@martinlingstuyl
Copy link
Contributor Author

Can you also please update the docs as well related to this cmdlet?
You need to update the Set-PnPContentType.md file which is in the documentation folder?
Let me know if you need more info from me :)

Aaahh, I was looking for that, but apparently I did not look good enough 😁

@gautamdsheth
Copy link
Collaborator

All good here, just really glad to have you contributing here 😊

Adding some parameter description would be enough for this. You can check other docs for reference.
What would be awesome (not required) is to have some examples. If we add some examples, they will get automagically picked by the predictor tool 😊🙏

@martinlingstuyl
Copy link
Contributor Author

I agree that's best. I'll add some soon!

@martinlingstuyl
Copy link
Contributor Author

That predictor tool is just awesome, right? 🚀

@gautamdsheth
Copy link
Collaborator

Ohhh it is sooo awesome !!! Absolutely, won't be going to back now to the old way 🔥🔥

@martinlingstuyl martinlingstuyl force-pushed the ct-form-customizer-options branch from 7696c8e to 79ebb0c Compare October 17, 2022 09:30
@martinlingstuyl
Copy link
Contributor Author

Alright @gautamdsheth. I added some documentation Examples + Parameter descriptions and rebased the entire thing on the latest dev branch. 🤙

@gautamdsheth gautamdsheth merged commit 86372d4 into pnp:dev Oct 17, 2022
@gautamdsheth
Copy link
Collaborator

Merged , thank you so much 😊🙏

@martinlingstuyl martinlingstuyl deleted the ct-form-customizer-options branch October 17, 2022 14:43
@martinlingstuyl
Copy link
Contributor Author

That's fast 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhance the Set-PnPContentType commandlet to be able to set Form Customizer properties
2 participants