Added ping to check if destination server exists

pnp · May 22, 2023 · cc3c556 · cc3c556
1 parent 2f4518d
commit cc3c556
Showing 1 changed file with 35 additions and 3 deletions.
diff --git a/src/Commands/Base/ConnectOnline.cs b/src/Commands/Base/ConnectOnline.cs
@@ -9,6 +9,7 @@
 using System.IO;
 using System.Linq;
 using System.Management.Automation;
+using System.Net.NetworkInformation;
 using System.Reflection;
 using System.Security;
 using System.Security.Cryptography.X509Certificates;
@@ -54,7 +55,7 @@ public class ConnectOnline : BasePSCmdlet
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_SYSTEMASSIGNEDMANAGEDIDENTITY)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_USERASSIGNEDMANAGEDIDENTITYBYCLIENTID)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_USERASSIGNEDMANAGEDIDENTITYBYPRINCIPALID)]
-        [Parameter(Mandatory = false, ParameterSetName = ParameterSet_USERASSIGNEDMANAGEDIDENTITYBYAZURERESOURCEID)]        
+        [Parameter(Mandatory = false, ParameterSetName = ParameterSet_USERASSIGNEDMANAGEDIDENTITYBYAZURERESOURCEID)]
         public SwitchParameter ReturnConnection;
 
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_CREDENTIALS, ValueFromPipeline = true)]
@@ -214,7 +215,7 @@ public class ConnectOnline : BasePSCmdlet
         public string UserAssignedManagedIdentityClientId;
 
         [Parameter(Mandatory = true, ParameterSetName = ParameterSet_USERASSIGNEDMANAGEDIDENTITYBYAZURERESOURCEID)]
-        public string UserAssignedManagedIdentityAzureResourceId;        
+        public string UserAssignedManagedIdentityAzureResourceId;
 
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_CREDENTIALS)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ENVIRONMENTVARIABLE)]
@@ -276,6 +277,11 @@ protected void Connect(ref CancellationToken cancellationToken)
                 credentials = Credentials.Credential;
             }
 
+            if (PingHost(new Uri(Url).Host) == false)
+            {
+                throw new PSArgumentException("Host not reachable");
+            }
+
             // Connect using the used set parameters
             switch (ParameterSetName)
             {
@@ -480,7 +486,7 @@ private PnPConnection ConnectAppOnlyWithCertificate()
                 {
                     throw new FileNotFoundException("Certificate not found");
                 }
-                
+
                 X509Certificate2 certificate = CertificateHelper.GetCertificateFromPath(this, CertificatePath, CertificatePassword);
                 if (PnPConnection.Current?.ClientId == ClientId &&
                     PnPConnection.Current?.Tenant == Tenant &&
@@ -696,6 +702,32 @@ private PnPConnection ConnectEnvironmentVariable(InitializationType initializati
         #endregion
 
         #region Helper methods
+
+        private static bool PingHost(string nameOrAddress)
+        {
+            bool pingable = false;
+            Ping pinger = null;
+
+            try
+            {
+                pinger = new Ping();
+                PingReply reply = pinger.Send(nameOrAddress);
+                pingable = reply.Status == IPStatus.Success;
+            }
+            catch (PingException)
+            {
+                // Discard PingExceptions and return false;
+            }
+            finally
+            {
+                if (pinger != null)
+                {
+                    pinger.Dispose();
+                }
+            }
+
+            return pingable;
+        }
         private PSCredential GetCredentials()
         {
             var connectionUri = new Uri(Url);