ulfm: add MPIX_Comm_get_failed #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2204_get_failed
branch
2 times, most recently
from
8231dfd to
ac5c20a
Compare
|
A key here is when a sending process is killed, a recv from that process should return EDIT: EDIT: I guess EDIT: I guess the fundamental difference is in ch4 we do not always have a posted message queue. We maintain one with debugger support -- how expensive if we always do that? |
|
test:mpich/ch3/most ✔️ |
|
test:mpich/ch4/most |
raffenet
approved these changes
Apr 4, 2022
This routine -- int MPI_Comm_get_failed(MPI_Comm comm, MPI_Group *failed_group) , which returns a group of failed process, is in the current working ULFM proposal.
Gather ULFM related functions together. These functions are related and are unstable. Gather them together to reduce conflicts when we change them.
This is adapted from ft/failure_ack.c. The current ft tests are disabled by wholesale. Add to impls to get it tested. MPIX functions need be in impls folder anyway. Unlike ft/failure_ack.c, this test only test the functionality of MPIX_Comm_get_failed. It does not test other fault-tolerance behaviors such as MPI_Recv and MPI_Finalize when some of the processes abruptly exit/fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add MPIX_Comm_get_failed. This function is in the current ULFM working proposal.
Ref: mpi-forum/mpi-issues#20 (comment)
This is a discovery function, the base of most ULFM applications. Let's support it.
Fixes: #5788
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.