coll: Add multileader allreduce composition #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/most |
tarudoodi
force-pushed
the
allreduce_multileader
branch
from
9e18a2d to
d8acaac
Compare
|
test:mpich/ch4/most |
|
@yfguo The testing passed successfully on this and it is ready for review. |
tarudoodi
force-pushed
the
allreduce_multileader
branch
from
d8acaac to
8432cc1
Compare
|
test:mpich/ch4/most |
|
The failed test is a timeout |
|
test:mpich/ch4/most |
yfguo
approved these changes
Apr 7, 2022
Co-authored-by: Surabhi Jain <[email protected]>
Multi-leaders based composition: It has `num_leaders` per node, which reduce the data within sub-node_comm. It is followed by intra_node reduce and inter_node allreduce on the piece of data the leader is responsible for. A shared memory buffer is allocated per leader. If size of message exceeds this shm buffer, the message is chunked. Constraints: For a comm, all nodes should have same number of ranks per node, op should be commutative. Co-authored-by: Surabhi Jain <[email protected]>
Co-authored-by: Surabhi Jain <[email protected]>
tarudoodi
force-pushed
the
allreduce_multileader
branch
from
8432cc1 to
8e9504a
Compare
|
test:mpich/ch4/most |
|
test:mpich/ch4/ofi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Multi-leaders based composition: It has
num_leadersper node, which reduce the data within sub-node_comm. It is followed by intra_node reduce and inter_node allreduce on the piece of data the leader is responsible for. A shared memory buffer is allocated per leader. If size of message exceeds this shm buffer, the message is chunked.Constraints: For a comm, all nodes should have same number of ranks per node, op should be commutative.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.