Fix spawn functionality with pmi2 #5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffenet
force-pushed
the
pmi2-spawn
branch
2 times, most recently
from
3e08da7 to
0740b0e
Compare
|
test:mpich/pmi |
3 similar comments
|
test:mpich/pmi |
|
test:mpich/pmi |
|
test:mpich/pmi |
|
test:mpich/pmi |
Use the correct key (PORT_KEY) to search the lookup response message.
appnum was always hardcoded to 0 in the PMI2_Init response. Get the information out of the executable list and return it like in pmi1.
This causes a compile error if not using pmi1.
This value is used in a couple different places in the device. Define it once in a header instead of in multiple files. Fixes a compile error with ch3:sock + pmi2.
|
test:mpich/pmi |
1 similar comment
|
test:mpich/pmi |
|
test:mpich/pmi |
Eliminate duplicate code already present in the MPIR layer.
|
test:mpich/pmi |
1 similar comment
|
test:mpich/pmi |
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes in ch3, hydra, and simple pmi2.
test/mpi/spawnshould now pass in the--with-pmi=pmi2/simpleconfiguration.TODO: add support for PMI2_Job_Spawn insrc/util/mpir_pmi.c.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.