Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: supply empty mtest_mpix.h #5842

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented Feb 9, 2022

Pull Request Description

When testsuite autogen is run outside mpich, supply an empty
mtest_mpix.h so the testing can proceed. The header files is for mpich
specific extension and will fail with non-mpich implementation anyway.
The empty stub will allow strict testing to proceed.

The regular mpich testing is not affected since mpich's top level
autogen will always supply this file.

Fixes #5841

[skip warnings]

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou hzhou requested a review from raffenet February 9, 2022 17:51
@hzhou
Copy link
Contributor Author

hzhou commented Feb 9, 2022

test:mpich/ch4/ofi

When testsuite autogen is run outside mpich, supply an empty
mtest_mpix.h so the testing can proceed. The header files is for mpich
specific extension and will fail with non-mpich implementation anyway.
The empty stub will allow strict testing to proceed.

The regular mpich testing is not affected since mpich's top level
autogen will always supply this file.
@hzhou hzhou merged commit 8242b3b into pmodels:main Feb 9, 2022
@hzhou hzhou deleted the 2202_mtest_mpix branch February 9, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testsuite: missing include/mtest_mpix.h
2 participants