mpi/coll: add TSP-based scatter/ring-based-allgather algorithm for Ibcast #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/ofi |
|
@zhenggb72 Please take a look at the scatterv and bcast timeouts. |
zhenggb72
force-pushed
the
ibcast_scatterv_ring_allgatherv
branch
2 times, most recently
from
3cad084 to
e1bfd3c
Compare
|
test:mpich/ch4/ofi |
Fixed. Looks like all tests are passing now. I think it is ready for review. |
yfguo
approved these changes
Feb 9, 2022
zhenggb72
force-pushed
the
ibcast_scatterv_ring_allgatherv
branch
from
e1bfd3c to
a0f1e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This algorithm is similar to the existing scatter followed by recursive exchange-based allgather Ibcast algorithm.
This ring-based algorithm is similar to the idea used in Baidu's ring allreduce (https://www.tomshardware.com/news/baidu-svail-ring-allreduce-library,33691.html)
Pull Request Description
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.