-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodule: Update UCX to v1.12.0 #5812
Conversation
test:mpich/ch4/ucx |
e5ddbbc
to
9cd009b
Compare
test:mpich/ch4/ucx |
Did the user provide any details on the bug? MPICH is likely to be deployed with different external ucx versions, it is good to have some record on what works and what does not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm asking for more details. After chatting a bit more, I kind of suspect it was user error, but we will see. |
Here is the error behavior seen on ThetaGPU. Apparently this goes away with the newer UCX 1.12.0. I don't have an allocation on ThetaGPU, but might be able to try on a JLSE machine instead.
|
9cd009b
to
7ee90b4
Compare
Pull Request Description
A user reported seeing a bug when using the embedded UCX with MPICH 4.0, but went away with an external 1.12.0 install. Update submodule to 1.12.0, then backport once merged.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short description
Commit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.