config/fortran: clean up Fortran binding config options #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2201_disable_f08
branch
from
9709b8e to
f265370
Compare
|
test:mpich/custom --disable-f08 ✔️ Confirmed that f08 was disabled. |
|
test:mpich/custom |
raffenet
approved these changes
Feb 7, 2022
hzhou
force-pushed
the
2201_disable_f08
branch
from
f265370 to
9a054d7
Compare
|
test:mpich/ch3/tcp |
Sometime user may want to disable f08 even when their compiler passes the PAC_FC_2008_SUPPORT test. Add explicit --disable-f08 option for that.
The test suite is now configured independently and no longer need these variables.
Now we only use a single $FC compiler, there isn't a need to check compatibility between F77 and FC.
By default we will build all Fortran interfaces. However, sometime user may desire disable certain interface. Use separate options so user can easily do so. Currently the f90 interface depends on f77 interface. But it should be possible to only build f77, or only build f08, or build f77 + f08. Remove and replace the variable enable_fc from configure since it is ambiguous whether it refers to the FC compiler or the interface features.
hzhou
force-pushed
the
2201_disable_f08
branch
from
9a054d7 to
ce6d5a6
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add options to explicitly disable individual Fortran binding interfaces.
Clean up configure logic now that we use a single $FC compiler and separately configures test suite.
Fixes #5793
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.