mpl: Use CPU affinity functions with standard names #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your patch! Could you please sign and return the contributor's agreement to [email protected]? https://www.mpich.org/documentation/contributor-docs/ |
|
I will, but it'll take a few more days. |
giordano
force-pushed
the
mg/mpl-thread-musl
branch
from
8dfa867 to
4b11cca
Compare
|
I signed and submitted the CLA (I don't know how long it takes to be processed) and rebased this PR on |
The functions with leading underscores are internally used in some systems, but the user-facing ones are without underscores: https://linux.die.net/man/3/cpu_set. The underscore-prefixed names are not available on Musl systems, leading to a linking error: ``` [01:19:03] libtool: link: cc -fvisibility=hidden -DNDEBUG -DNVALGRIND -O3 -o src/env/.libs/mpichversion src/env/mpichversion.o lib/.libs/libmpi.so -lpthread -lm -Wl,-rpath -Wl,/workspace/destdir/lib [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to `__CPU_ISSET_S' [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to `__CPU_SET_S' [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to `__CPU_ZERO_S' [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to collect2: error: ld returned 1 exit status [01:19:03] `__CPU_ISSET_S' [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to `__CPU_SET_S' [01:19:03] /opt/x86_64-linux-musl/bin/../lib/gcc/x86_64-linux-musl/8.1.0/../../../../x86_64-linux-musl/bin/ld: lib/.libs/libmpi.so: undefined reference to `__CPU_ZERO_S' [01:19:03] collect2: error: ld returned 1 exit status [01:19:03] make[2]: *** [Makefile:14129: src/env/mpichversion] Error 1 [01:19:03] make[2]: *** Waiting for unfinished jobs.... [01:19:03] make[2]: *** [Makefile:14135: src/env/mpivars] Error 1 ```
giordano
force-pushed
the
mg/mpl-thread-musl
branch
from
4b11cca to
099bb98
Compare
|
Bump 🙂 CLA seems to have been accepted |
raffenet
approved these changes
Feb 23, 2022
|
I don't know why the warnings checker didn't report a status. I'll run a sanity check just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The functions with leading underscores are internally used in some systems, but
the user-facing ones are without underscores:
https://linux.die.net/man/3/cpu_set. The underscore-prefixed names are not
available on Musl systems, leading to a linking error:
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.