op: replace predefined datatype on input #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch3/most |
hzhou
force-pushed
the
2201_op_predef
branch
from
f3eeddf to
0b172fa
Compare
|
test:mpich/ch3/most |
raffenet
reviewed
Feb 14, 2022
Comment on lines
+99
to
+105
| if (dt_ptr && dt_ptr->contents) { | ||
| int combiner = dt_ptr->contents->combiner; | ||
| if (combiner == MPI_COMBINER_F90_REAL || | ||
| combiner == MPI_COMBINER_F90_COMPLEX || combiner == MPI_COMBINER_F90_INTEGER) { | ||
| if (MPI_SUCCESS == (*MPIR_OP_HDL_TO_DTYPE_FN(op)) (dt_ptr->basic_type)) { | ||
| alt_dt = dt_ptr->basic_type; | ||
| } |
There was a problem hiding this comment.
Is there any reason not to use MPIR_Datatype_get_basic_type instead of checking the combiner?
There was a problem hiding this comment.
basic_type will not tell us whether it is one of the predefined F90 types, right?
There was a problem hiding this comment.
@raffenet Is this question resolved?
There was a problem hiding this comment.
I think so. Wasn't totally aware of these "predefined" types in the standard. Calls into question some of the code that identifies predefined datatypes in MPICH, but that's a separate story.
raffenet
approved these changes
Feb 21, 2022
We are supposed to support operations on some predefined datatype, such as those from MPI_Type_create_f90_xxx. However, those types are in fact derived types wraps around a basic type. Check and replace the input datatype with the basic type if that is the case so the reduction can work. Since the datatype in these case are all input only parameters, there shouldn't be any side effects replacing them.
hzhou
force-pushed
the
2201_op_predef
branch
from
0b172fa to
bc7f81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We are supposed to support operations on some predefined datatype, such
as those from MPI_Type_create_f90_xxx. However, those types are in fact
derived types wraps around a basic type. Check and replace the input
datatype with the basic type if that is the case so the reduction can
work. Since the datatype in these case are all input only parameters,
there shouldn't be any side effects replacing them.
Fixes #1769
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.