ch4: return node_id -1 for remote processes #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/ofi |
|
test:mpich/ch4/ucx |
raffenet
approved these changes
Jul 20, 2021
Remote processes, coming from different MPI_COMM_WORLD, can't use shared memory because the necessary initialization is not done. Let's return node_id -1 MPIDU_get_node_id as an indication that the process is remote. This will prevent MPIR_Find_local to include remote processes as part of local processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Remote processes, coming from different MPI_COMM_WORLD, can't use shared
memory because the necessary initialization is not done. Let's return
node_id -1 MPIDU_get_node_id as an indication that the process is
remote. This will prevent MPIR_Find_local to include remote processes as
part of local processes.
Fixes #5372
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.