Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi/test/threads: add declaration of MTest_thread_yield #4503

Merged
merged 1 commit into from
May 6, 2020
Merged

mpi/test/threads: add declaration of MTest_thread_yield #4503

merged 1 commit into from
May 6, 2020

Conversation

shintaro-iwasaki
Copy link
Contributor

Pull Request Description

This PR fixes a bug in #4421. An external function, MTest_thread_yield(), was newly added but not declared in mpithreadtest.h. This PR adds a
declaration of MTest_thread_yield() in this header.

This issue has been reported by @hzhou. Thank you!

Expected Impact

This is a bug fix.

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • You or your company has a signed contributor's agreement on file with Argonne
  • For non-Argonne authors, request an explicit comment from your companies PR approval manager

@shintaro-iwasaki shintaro-iwasaki mentioned this pull request May 6, 2020
Merged
9 tasks
hzhou
hzhou approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes it. Thanks.

@hzhou hzhou merged commit 32a7fea into pmodels:master May 6, 2020
@shintaro-iwasaki shintaro-iwasaki deleted the DeclareMtestThreadYield branch October 30, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhou hzhou hzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shintaro-iwasaki @hzhou