Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/workflows): add validating PR title action #3023

Closed

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Feb 20, 2025

Summary

We follow the Conventional Commits rules as defined in CONTRIBUTING.md's commiting section.
In a workflow that follows the squash and merge rule, I believe the committing conventions also apply to PR titles. However, there have been instances where PRs were merged without adhering to these rules.

To enforce consistency, this PR introduces a GitHub Action that:

  • Validates whether PR titles follow the Conventional Commits format
  • Prevents merging if the title does not comply with the rules
  • Helps maintain a structured and standardized commit history

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 3:08am

Copy link

codesandbox-ci bot commented Feb 20, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Feb 20, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@3023

commit: 24ecfb5

@dai-shi
Copy link
Member

dai-shi commented Feb 20, 2025

I don't think we need this for now. Let's revisit this in the future, after we have many cases that we are not happy with.

@dai-shi dai-shi closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants