Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(create.md): fix state selector syntax in troubleshooting example #2938

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

HoberMin
Copy link
Contributor

@HoberMin HoberMin commented Jan 6, 2025

Related Bug Reports or Discussions

Fixes #

Summary

Fixed incorrect state selector syntax in the troubleshooting example of create.md. The original code had a circular reference issue where person and setPerson were trying to reference themselves. Updated the selectors to correctly access the state and setPerson from the store state.

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 8:37am

Copy link

codesandbox-ci bot commented Jan 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@2938

commit: 7cfe5c4

Copy link
Collaborator

@dbritto-dev dbritto-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbritto-dev dbritto-dev merged commit efaf416 into pmndrs:main Jan 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants