-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shallow): Attempt Byte shave #2307
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46f2dd9:
|
Size Change: -5 B (0%) Total Size: 7.42 kB
ℹ️ View Unchanged
|
if (Object.is(objA, objB)) { | ||
return true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of like this style. While we don't use it, eslint has a rule for this: https://eslint.org/docs/latest/rules/curly
I wonder if there's a rollup plugin or something to transpile it to remove {}
at the build step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. I'll take a look for plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find anything on my first search. I'm sure there's a way to do this, but I'm not very fluent with Rollup plugins, so I'll close this PR for now because I don't intent to find a plugin. Thank you for understanding.
Related Issues or Discussions
Summary
Check List
yarn run prettier
for formatting code and docs