Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shallow): Attempt Byte shave #2307

Closed
wants to merge 1 commit into from
Closed

Conversation

charkour
Copy link
Collaborator

Related Issues or Discussions

Summary

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:38pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46f2dd9:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@charkour
Copy link
Collaborator Author

Size Change: -5 B (0%)

Total Size: 7.42 kB

Filename Size Change
dist/vanilla/shallow.js 964 B -5 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/index.js 244 B
dist/middleware.js 4.08 kB
dist/middleware/immer.js 328 B
dist/react.js 493 B
dist/react/shallow.js 216 B
dist/shallow.js 191 B
dist/traditional.js 464 B
dist/vanilla.js 436 B

compressed-size-action

Comment on lines -2 to -4
if (Object.is(objA, objB)) {
return true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like this style. While we don't use it, eslint has a rule for this: https://eslint.org/docs/latest/rules/curly
I wonder if there's a rollup plugin or something to transpile it to remove {} at the build step.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. I'll take a look for plugins.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find anything on my first search. I'm sure there's a way to do this, but I'm not very fluent with Rollup plugins, so I'll close this PR for now because I don't intent to find a plugin. Thank you for understanding.

@charkour charkour closed this Jan 23, 2024
@charkour charkour deleted the byte-shave branch April 6, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants