Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand tracking resets hand position if tracking lost causing weird visual effects #273

Closed
Ledzz opened this issue May 24, 2023 · 2 comments · Fixed by #283
Closed

Hand tracking resets hand position if tracking lost causing weird visual effects #273

Ledzz opened this issue May 24, 2023 · 2 comments · Fixed by #283
Labels
bug Something isn't working

Comments

@Ledzz
Copy link
Contributor

Ledzz commented May 24, 2023

If the tracking is lost, hands are reset to (0, 0, 0) position.

To reproduce:

Actual result:
You see a hand model in idle state in (0,0,0) coordinates (where you stand)

Expected result:
Hand model is hidden

My idea to fix it was to find parent element (armature itself) and if its position is strictly (0,0,0) just hide the hand.
But I find this check too loose: maybe the coordinates will be not exacly 0.
Do you have any ideas?

@CodyJasonBennett CodyJasonBennett added the bug Something isn't working label May 24, 2023
@CodyJasonBennett
Copy link
Member

I believe events are dispatched when the input method changes. Will have to see if that's true for hands in this case or only if controllers are then activated.

@Ledzz
Copy link
Contributor Author

Ledzz commented May 24, 2023

I've checked, events are dispatched when the tracking is lost. I'll try to fix it tomorrow.

saitonakamura pushed a commit that referenced this issue Jul 6, 2023
Fixes #273

Me a @saitonakamura checked how the events were sent and found some issues with code not cleaning up, not disposing used resources and not hiding hands when they are not tracking. We decided to add OculusHandModel and XRHandMeshModel to this library so the fix is ready for usage as soon as possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants