Prevent usage of getElapsedTime #3455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99ba76d:
|
|
We could consider moving to Timer instead of using the clock in the main state. Learned about it while talking about the getElapsedTime issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this PR to Drei
The doc currently encourage people to use
.getElapsedTime()for animations, while they should never ( as far as I can think of ) call it. If they need the elapsedTime they can read it from.elapsedTimethat is updated by the internal call to getDelta.Otherwise the next delta of the whole app will be affected.
This PR updates the doc and add a warning to each call to
getElapsedTime()for the main state clock.Edit: We could make a second warning for calls to getDelta but I never seen this being used by mistake.