chore(types): suppress errors with @ts-expect-error directive instead of @ts-ignore #3259
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6148010:
|
packages/fiber/src/core/utils.ts
Outdated
| @@ -7,9 +7,7 @@ import { AttachType, catalogue, Instance, InstanceProps, LocalState } from './re | |||
| import { Dpr, Renderer, RootState, Size } from './store' | |||
|
|
|||
| // < r141 shipped vendored types https://github.com/pmndrs/react-three-fiber/issues/2501 | |||
| /** @ts-ignore */ | |||
There was a problem hiding this comment.
Note that any /** @ts-ignore */ is intended to be kept and are user-facing at build-time #3062. This won't be an issue in v9.
There was a problem hiding this comment.
@CodyJasonBennett But why? The build doesn't seem to fail because there's no error for them. Am I missing something?
There was a problem hiding this comment.
Some of these types are removed in future three types, but we need to keep them here so they are dynamically used if available.
There was a problem hiding this comment.
Ah, got it, I'll get them back then.
Great thing tho that v9 will have those being fully dynamic: #3038 (comment) 💎
CodyJasonBennett
changed the title
About
Using @ts-expect-error is preferred over @ts-ignore and considered a better practice.
To see why, check out this great article by @mattpocock: How to use @ts-expect-error
Exceptions
User-facing
/** @ts-ignore */pragmas are preserved due to #3062