Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): should update with conditional dependencies #2086

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 22, 2023

Related Issues or Discussions

Fix #2084

Summary

This is a regression from v1. We should update atoms correctly with conditional dependencies.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 11:12am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8dee56b:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration
still-bird-xdgd7t Issue #2084

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Size Change: +230 B (0%)

Total Size: 67.9 kB

Filename Size Change
dist/system/vanilla.development.js 3.93 kB +56 B (+1%)
dist/system/vanilla.production.js 1.94 kB +34 B (+2%)
dist/umd/vanilla.development.js 4.72 kB +54 B (+1%)
dist/umd/vanilla.production.js 2.16 kB +31 B (+1%)
dist/vanilla.js 4.64 kB +55 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 907 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.38 kB
dist/index.js 242 B
dist/react.js 1.05 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 757 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.56 kB
dist/system/babel/preset.production.js 1.13 kB
dist/system/index.development.js 236 B
dist/system/index.production.js 167 B
dist/system/react.development.js 1.17 kB
dist/system/react.production.js 701 B
dist/system/react/utils.development.js 713 B
dist/system/react/utils.production.js 451 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 175 B
dist/system/vanilla/utils.development.js 4.51 kB
dist/system/vanilla/utils.production.js 2.76 kB
dist/umd/babel/plugin-debug-label.development.js 1.06 kB
dist/umd/babel/plugin-debug-label.production.js 845 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.24 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.42 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla/utils.development.js 5.24 kB
dist/umd/vanilla/utils.production.js 3.23 kB
dist/utils.js 246 B
dist/vanilla/utils.js 5.1 kB

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review August 22, 2023 01:16
@dai-shi dai-shi added this to the v2.4.0 milestone Aug 22, 2023
@dai-shi dai-shi merged commit 0e501cb into main Aug 23, 2023
@dai-shi dai-shi deleted the fix/issue-2084 branch August 23, 2023 11:19
dai-shi added a commit that referenced this pull request Sep 2, 2023
dai-shi added a commit that referenced this pull request Sep 2, 2023
dai-shi added a commit that referenced this pull request Sep 7, 2023
* add failing test

* revert #2086 change

* fix #2086 with a different approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalidation / re-evaluation of atoms is broken
1 participant