Fix aquarium demo #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernier
reviewed
Jul 31, 2024
| @@ -8,7 +8,7 @@ import turtleModel from './model_52a_-_kemps_ridley_sea_turtle_no_id-transformed | |||
|
|
|||
| export default function App({ spheres }) { | |||
| return ( | |||
| <Canvas shadows camera={{ position: [30, 0, -3], fov: 35, near: 1, far: 50 }}> | |||
| <Canvas shadows camera={{ position: [30, 0, -3], fov: 35, near: 1, far: 50 }} gl={{ stencil:true }}> | |||
There was a problem hiding this comment.
is this gl={{ stencil:true }} really necessary in this case? I tried without, seems to have no effect :/
There was a problem hiding this comment.
Without it the turtle and the spheres were not clipping to the inside of the aquarium. I was using the fix for the issue mentioned in the description.
The default value is false from r163 onwards.
mrdoob/three.js#27900
There was a problem hiding this comment.
without gl={{ stencil:true }}
with gl={{ stencil:true }}
|
this one should have the CI failed (because this demo has a visual test defined + your edits change the rendering) -- but it didn't and make me realise that the CI still needs tweaks: #34 so I keep it open until I've fixed this ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMask hook and Mask component doesn't work with the current version of three.js drei#1949