This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Syscall format test fix #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make some lines in the match file optional, those which were made optional in bb10939
To match the ctest test name.
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 11 11
Lines 957 957
=======================================
Hits 880 880
Misses 77 77
Continue to review full report at Codecov.
|
|
Reviewed 3 of 4 files at r1. Comments from Reviewable |
|
Something similar should be done for O_TMPFILE. Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #76
Whether the kernel support mlock2 or not, whether libc gives a constant SYS_mlock2 or not, has no effect on being able to intercept syscalls.
The syscall logging is an "extra feature" anyways, shouldn't stop people from using syscall_intercept.
This change is