run_qemu.sh: drop mkosi --autologin, use systemd credentials instead #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until mkosi v24 commit c236c9f7b9c82d3, `mkosi --autologin` used to be applied to four devices: console, tty1, ttyS0 and one architecture-dependent device. mkosi has some QEMU features of its own to boot the image. run_qemu.sh never used any of that. We should probably try (some of) it in the future but I digress. In that mkosi commit, `mkosi/qemu.py` (which we don't use) stopped using `ttyS0` and replaced it with the faster `/dev/hvc0` instead. The image building code (which we DO use!) was updated correspondingly without caring about backwards compatibility and dropped ttyS0 on the floor. Someone noted this in systemd/mkosi#2834 and the recommendation was to switch to systemd credentials: exactly what this commit does. The mkosi maintainer also expressed the possible removal of `--autologin` in the future. Pros: - Completely removes the autologin dependency on the changing mkosi behavior. Compatible with any mkosi version. - Applies to all terminals, zero hardcoded name. - Simpler, clearer and more direct implementation: zero configuration file! - More dynamic: changes and tests do not require rebuilding anything. Cons: - Requires systemd v251 or above (May 2022) - Applies to all terminals but could be more selective when using "per-instance" systemd credentials added in v257 (December 2024) Signed-off-by: Marc Herbert <[email protected]>
|
@davejiang please confirm this works for you before this get merged. |
To clarify: people building with systemd < v251 (e.g. building Ubuntu 22.04 images) will lose autologin but nothing else. |
I just got a confirmed Tested-by: @davejiang Now this just needs a Reviewed-by: :-) |
stellarhopper
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until mkosi v24 commit c236c9f7b9c82d3,
mkosi --autologinused to be applied to four devices: console, tty1, ttyS0 and one architecture-dependent device.mkosi has some QEMU features of its own to boot the image. run_qemu.sh never used any of that. We should probably try (some of) it in the future but I digress. In that mkosi commit,
mkosi/qemu.py(which we don't use) stopped usingttyS0and replaced it with the faster/dev/hvc0instead. The image building code (which we DO use!) was updated correspondingly without caring about backwards compatibility and dropped ttyS0 on the floor. Someone noted this insystemd/mkosi#2834 and the recommendation was to switch to systemd credentials: exactly what this commit does. The mkosi maintainer also expressed the possible removal of
--autologinin the future.Pros:
Cons: