-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement JSON value matching #500
base: main
Are you sure you want to change the base?
Conversation
4acf111
to
8231fa1
Compare
8231fa1
to
be06abf
Compare
@drewjenkins This PR fixes binance and Spotify, but requires breaking changes to the attest-integrations. @piotr-roslaniec , can you help Andrew update the attest-integrations (link) to reflect your changes? Also, we will need to update the docs for this new manifest description, @0xFloyd can you work with Piotr to update the docs? |
@piotr-roslaniec @devloper Does the rename from
|
@drewjenkins The renaming of the field is optional, but how it's interpreted will change, breaking some stuff: Previously we didn't expect the last element in the I updated the issue description. This is the only breaking change I foresee before we roll-out a DSL, which will break everything. |
Thanks for writing up the great list Andrew! We should almost make this into a check list for releasing these breaking changes quickly. imo these breaking changes are perfectly fine and we should not be "afraid" to make them as long as we have good semantic versioning we should have control over when the changes goes out to all our SDKs and users can choose when they upgrade. We may need to improve our release management processes however to minimize the headache for ourselves. |
NotaryResponse
andNotaryResponseBody
to separateManifestResponse
and verification logic & parsing JSONManifest.body.json
now describes JSON path with an optional value matching