Feat/build profiles #381
Feat/build profiles #381
Conversation
|
Fixed the little merge conflict. But you will have to rebase with main to fix the notary/deploy issue. |
|
Building "notary --debug" in the notary workflow means we will deploy a debug version to the staging instance. I'm torn if that's cool or not. Thoughts? Presumably at some point in the future we'd like to attach a prebuilt version of the "notary --release" to the Github Release? I noticed we are only using macos-latest for client. Should we bring back support for ubuntu-latest as well? |
hmm this is a good thought. I think maybe debug version is good for now. My thoughts here are that the notary isn't performance bound so the release flag doesn't do a whole lot for it here but it does increase the build time by about 3minutes. I do like the idea of at somepoint in the future maybe after #380 and the back-end test-net project we can be in a better place to do that? What do you think? |
0xJepsen
force-pushed
the
feat/build_profiles
branch
from
e81e513 to
8e402e4
Compare
|
Gave this a rebase not sure what needs to happened here. |
.github/workflows/notary.yaml
Outdated
| @@ -49,7 +49,8 @@ jobs: | |||
| path: proofs/web_proof_circuits | |||
| key: ${{ needs.setup.outputs.cache-key }} | |||
|
|
|||
| - run: cargo +nightly-2024-10-28 build -p notary --release | |||
| - run: cargo +nightly-2024-10-28 build -p notary | |||
| - uses: Swatinem/rust-cache@v2 | |||
There was a problem hiding this comment.
Remove - uses: Swatinem/rust-cache@v2 here, this cache action needs to run before the actual build to pull in the cached files. This is currently already happening in line 33.
|
This artifact action is expecting a Write artifact here: https://github.com/pluto/web-prover/pull/381/files#diff-cf936e8fd1e64fac1eca112295f2ebdd20f5e01f0ce2b7a95f59c2be07a24a08L58 Read artifact here: https://github.com/pluto/web-prover/pull/381/files#diff-cf936e8fd1e64fac1eca112295f2ebdd20f5e01f0ce2b7a95f59c2be07a24a08R78 |
|
I just remembered something, TLS Notary in debug build does not work. Proof times are too slow. So it actually probably the case we need to run the |
Closes #370
Left a bunch of notes in the issue that describe my results. tldr is that this should cut off about 6 minutes of CI