Feat: FFT and Ifft implemented with tests #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
requested changes
Feb 17, 2025
src/polynomial/mod.rs
Outdated
| /// Computes the Fast Fourier Transform (FFT) of a polynomial in the Monomial basis. | ||
| pub fn fft(&self) -> Polynomial<Lagrange<F>, F, D> { | ||
| let n = self.num_terms(); | ||
| assert!(n.is_power_of_two(), "Length must be power of 2"); |
There was a problem hiding this comment.
self.num_terms() is actually just D.
My suggestion would be to make note of this throughout this whole module and then we don't need assertions that get ran at runtime. We can instead just have compile time checking with const generics. What do you think?
There was a problem hiding this comment.
i tried some fix , but it might affect some tests
There was a problem hiding this comment.
@Autoparallel is the fix in anyway what you wanted , it will restrict creating non power of two numbered coefficient polynomials , hence the failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #30