Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manages selinux state around salt execution #342

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Manages selinux state around salt execution #342

merged 1 commit into from
Jul 8, 2017

Conversation

lorengordon
Copy link
Member

  • Tests if selinux is enforcing prior to salt state execution
  • If selinux is enforcing, set it to permissive mode
  • After salt completes, if selinux was enforcing previously,
    set it back to enforcing (even if salt raised an exception)

Fixes #341

* Tests if selinux is enforcing prior to salt state execution
* If selinux is enforcing, set it to permissive mode
* After salt completes, if selinux was enforcing previously,
  set it back to enforcing (even if salt raised an exception)

Fixes #341
@codecov
Copy link

codecov bot commented Jul 6, 2017

Codecov Report

Merging #342 into develop will decrease coverage by 0.13%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
- Coverage    24.62%   24.48%   -0.14%     
===========================================
  Files           13       13              
  Lines          865      878      +13     
  Branches        94       96       +2     
===========================================
+ Hits           213      215       +2     
- Misses         651      662      +11     
  Partials         1        1
Impacted Files Coverage Δ
src/watchmaker/workers/salt.py 14.14% <14.28%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2e94c...eeb60dd. Read the comment docs.

@lorengordon
Copy link
Member Author

@KevinPlus3 this is passing our internal tests, any concerns?

@lorengordon lorengordon merged commit d21362f into plus3it:develop Jul 8, 2017
@lorengordon lorengordon deleted the issue-341 branch July 8, 2017 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants