Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightens the logic getting the current version to avoid multiple returns #16

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Tightens the logic getting the current version to avoid multiple returns #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545623f
Tightens the logic getting the current version to avoid multiple returns
lorengordon Jun 20, 2023
aa26414
Bumps version to 1.2.1
lorengordon Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.2.0
current_version = 1.2.1
commit = True
message = Bumps version to {new_version}
tag = False
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
set -eu -o pipefail
RELEASE=false
PRIOR_VERSION=$(git describe --abbrev=0 --tags || true)
RELEASE_VERSION=$(grep current_version .bumpversion.cfg | sed 's/^.*= //' )
RELEASE_VERSION=$(grep -E "current_version\s*=" .bumpversion.cfg | sed 's/^.*= //' )
if [[ "$PRIOR_VERSION" != "$RELEASE_VERSION" ]]; then RELEASE=true; fi
echo "condition=${RELEASE}"
echo "version=${RELEASE_VERSION}"
Expand Down