tests: further deflake watcher tests for travis-ci #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(triggering a bunch of builds until I get the rare failure + backtraces) |
|
couldn't trigger the failure again despite a bunch of retries ... will just leave this open a while in case another PR gets it again |
ploxiln
force-pushed
the
watcher_still_flaky
branch
from
3e35b01 to
cf7707f
Compare
move goroutine loop into named function, to make debugging backtraces a bit easier make debugging backtraces a bit easier since the watcher tests are still a bit flaky on travis-ci extend replacement wait time from 2 seconds to 5 seconds - originally it looped waiting indefinitely, so make it a bit more forgiving, hopefully it won't be a big problem for many users ;)
ploxiln
force-pushed
the
watcher_still_flaky
branch
from
cf7707f to
487750f
Compare
|
I haven't been able to see the test failure on travis-ci again in the past 40 or so attempts across various PRs so I'm giving up. I also never succeeded in seeing any failure when testing locally, after the last watcher-test-deflake PR, #3. Maybe the rare-linux-hang fix in fsnotify v1.4.7 will help prevent these test failures ever re-occuring. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start by making backtraces a bit easier to read