more robust redirect url handling #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
flex_redirect
branch
from
b49e378 to
c9fa775
Compare
ploxiln
changed the title
ploxiln
force-pushed
the
flex_redirect
branch
from
fb2e47f to
804fcfb
Compare
accept rd param and X-Auth-Request-Redirect header from both /sign_in and /start handlers avoid accidental redirect to either .../sign_in or .../start handlers
tricky open-redirect vulnerability, see GHSA-qqxw-m5fj-f7gv
ploxiln
force-pushed
the
flex_redirect
branch
from
804fcfb to
6c1b9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept rd param and X-Auth-Request-Redirect header from
both /sign_in and /start handlers
avoid accidental redirect to either /sign_in or /start handlers
inspired by oauth2-proxy/oauth2-proxy#150
Updated in February 2020 with the related:
check for /\ redirects
tricky open-redirect vulnerability, see
GHSA-qqxw-m5fj-f7gv