Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share i18n #246

Merged
merged 4 commits into from
Jan 17, 2018
Merged

Share i18n #246

merged 4 commits into from
Jan 17, 2018

Conversation

alexcjohnson
Copy link
Collaborator

  • Generalizes the translation scripts @VeraZab made so we can reuse them in batch (didn't work for findTranslationKeys due to the different babel versions... but the other two are shared)
  • Localizes a few more things that were missed earlier

@alexcjohnson alexcjohnson mentioned this pull request Jan 17, 2018
Merged
@alexcjohnson
Copy link
Collaborator Author

@VeraZab can you give this a quick review, then help me publish it so I can use it in https://github.com/plotly/plotly.js-batch-reporter/pull/24 ?

@alexcjohnson alexcjohnson requested a review from VeraZab January 17, 2018 15:43
@VeraZab
Copy link
Contributor

VeraZab commented Jan 17, 2018

yeah, was looking at it, well, looks good, so you'd like a new patch release?

@alexcjohnson
Copy link
Collaborator Author

alexcjohnson commented Jan 17, 2018 •
edited
Loading

so you'd like a new patch release?

yes please 🙏

@alexcjohnson alexcjohnson merged commit 82d5c92 into master Jan 17, 2018
@alexcjohnson alexcjohnson deleted the share-i18n branch January 17, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeraZab VeraZab Awaiting requested review from VeraZab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcjohnson @VeraZab