Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bar.width to be Option<f64> #230

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Make Bar.width to be Option<f64> #230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868d95f
Make Bar.width to be Option<f64>
Ionizing Aug 27, 2024
377b259
make bar offset float as well
andrei-ng Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make Bar.width to be Option<f64>
  • Loading branch information
@Ionizing @andrei-ng
Ionizing authored and andrei-ng committed Sep 6, 2024
commit 868d95fb348efb5dd687c07e46c61356969db435
6 changes: 3 additions & 3 deletions plotly/src/traces/bar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ where
legend_group_title: Option<LegendGroupTitle>,
opacity: Option<f64>,
ids: Option<Vec<String>>,
width: Option<usize>,
width: Option<f64>,
offset: Option<Dim<usize>>,
text: Option<Dim<String>>,
#[serde(rename = "textposition")]
Expand Down Expand Up @@ -178,7 +178,7 @@ mod tests {
.text_template("text_template")
.text_template_array(vec!["text_template"])
.visible(Visible::LegendOnly)
.width(999)
.width(999.0)
.x_axis("xaxis")
.x_calendar(Calendar::Nanakshahi)
.y_axis("yaxis")
Expand All @@ -197,7 +197,7 @@ mod tests {
"legendgrouptitle": {"text": "legend-group-title"},
"opacity": 0.5,
"ids": ["1"],
"width": 999,
"width": 999.0,
"offset": [5, 5],
"text": ["text"],
"textposition": ["none"],
Expand Down