Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy::manual_unwrap_or_default triggers on macro generated code from darling crate #210

Closed
andrei-ng opened this issue Jun 18, 2024 · 1 comment
Closed

clippy::manual_unwrap_or_default triggers on macro generated code from darling crate #210

andrei-ng opened this issue Jun 18, 2024 · 1 comment
Assignees
@andrei-ng
Labels
ci dependencies Pull requests that update a dependency file

Comments

@andrei-ng
Copy link
Collaborator

andrei-ng commented Jun 18, 2024 •
edited
Loading

Temporarily, the CI has been fixed by adding -Aclippy::manual_unwrap_or_default to all clippy jobs.

These should be removed from CI workflow file once the issue is fixed upstream.
See:
rust-lang/rust-clippy#12643
TedDriggs/darling#293
@andrei-ng andrei-ng self-assigned this Jun 18, 2024
@andrei-ng andrei-ng added dependencies Pull requests that update a dependency file ci labels Jun 18, 2024
@TedDriggs
Copy link

The fix for this has moved to TedDriggs/darling#296

andrei-ng added a commit that referenced this issue Jul 31, 2024
@andrei-ng
revert CI clippy darling package command patch
d27cf18 
 - temporary patch introduced in
   3130f5a to bypass clippy errors
   due to darling package: TedDriggs/darling#296

Closes #210

Signed-off-by: Andrei Gherghescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-ng andrei-ng

Labels
ci dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TedDriggs @andrei-ng