Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FigureWidget.show to return FigureWidget instead of displaying Figure #4869

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix FigureWidget.show to return FigureWidget instead of displaying Figure #4869

merged 2 commits into from
Nov 13, 2024

Conversation

marthacryan
Copy link
Collaborator

Fixes #4854 by overriding the BaseFigure parent class implementation of show() that FigureWidget inherits (see issue for more context). This changes the behavior to be the same as between these two cases (assuming fig = go.FigureWidget()):

  • fig
  • fig.show()

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Nov 13, 2024
@marthacryan marthacryan merged commit ffb571b into master Nov 13, 2024
5 checks passed
@marthacryan marthacryan deleted the widget-show branch January 28, 2025 18:05
@turbotimon turbotimon mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvwilson gvwilson gvwilson approved these changes

Assignees

@marthacryan marthacryan

Labels
fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FigureWidget.show() returns a Figure instead of a FigureWidget
2 participants
@marthacryan @gvwilson