-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Px special inputs #2330
Px special inputs #2330
Conversation
@@ -41,6 +41,30 @@ def __init__(self): | |||
defaults = PxDefaults() | |||
del PxDefaults | |||
|
|||
|
|||
class IdentityMap(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could these two classes be moved to a _special_inputs.py
file to shorten a bit _core.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you wish, I just feel that the length of this file makes it a bit overwhelming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Thanks for the PR! I'm completely convinced by I'll do more QA on examples tomorrow, tonight I only had time for a quick pass reading the code. |
So |
Ah ok thanks for the explanations, I had not understood how the class worked. Maybe add a line with your explanation above in the docstring of the class? |
So I've experimented a bit with your branch. It works well as expected. From a pure usability point of view, doing something like |
Yep, |
OK I addressed your feedback, including the |
Oops... reading again our convo in #2119 I think I had preferred option 2 because it used a constant instead of a function or a class, but eventually it's not a constant... |
I added this in: you can use I can implement |
Thanks for implementing the
|
I was going to document everything in the last PR :) |
Superseded by #2336 |
Closes #2119 ... @emmanuelle LMK what you think of the API and testing approach and if it makes sense I'll document it.