Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Double-Click Feature that Isolates Legend-Items #871

Closed
wants to merge 1 commit into from
Closed

Added Double-Click Feature that Isolates Legend-Items #871

wants to merge 1 commit into from

Conversation

erasabi
Copy link

@erasabi erasabi commented Aug 19, 2016

Thanks for your interest in plotly.js!

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master
  • make sure to not git add the dist/ folder (the dist/ is updated only on verion bumps)
  • write an overview of what the PR attempts to do.

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

@erasabi
Copy link
Author

erasabi commented Aug 19, 2016

Please review my PR and get back to me

@etpinard
Copy link
Contributor

etpinard commented Aug 19, 2016

Please read the Before opening a pull request, developer should: section above.

@erasabi
Copy link
Author

erasabi commented Aug 19, 2016

okay, no problem.

On Fri, Aug 19, 2016 at 3:36 PM, Étienne Tétreault-Pinard <
[email protected]> wrote:

Please read to Before opening a pull request, developer should: section
above.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#871 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/APD0-to6t38G_0m2uHI70JP3gxtXVp4yks5qhgWqgaJpZM4JoyNI
.

@etpinard
Copy link
Contributor

etpinard commented Sep 1, 2016

Closing because of lack of activity.

Discussion should be continued in #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants