-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise scatter register to allow custom partial bundles without scatter included by default #5535
base: master
Are you sure you want to change the base?
Conversation
Pretty cool, doesn't seem like it was that hard to make this work 😎 We'll need to do something about the default trace type - the two options that occur to me are (1) use the first trace type registered, or (2) if In addition to the bundle tests verifying behavior without |
Can we timebox this PR's remaining work to 1 hour please? This one is out of scope for the work in v2 at this point, and getting RC.1 out the door and fixing the bugs on the roadmap should take priority now :) |
The second option is applied in 45d3764. |
45d3764
to
b0766a7
Compare
Loggers.log('The default trace type ' + dfltTrace + ' is not registered.'); | ||
|
||
// in case the category starts with no return true otherwise false | ||
return category.indexOf('no') === 0 ? true : false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it important to return true
here for the no
categories? In what situation would this occur?
…es-without-scatter
This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson |
@archmoj this is tied to a ticket you closed in 2021 - can we please close this PR? |
Follow up of #5527,
Registering scatter trace outside
core
vialib/scatter
(which used to be unused) so that one could create custom partial bundles without scatter+cartesian overhead.cc: #5395
@plotly/plotly_js