-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5291: recalculation of dynamic CSS transforms on hover #5302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the follow up PR.
Please find my comments below.
Currently changing tests slightly to check the changes work. Having some issues with the polar tests failing when they shouldn't, will investigate. |
Here is a demo using the changes made by this branch. |
Fixing up syntax errors now - npm run test-syntax doesn't seem to be picking up a lot of my syntax errors, weirdly. I've installed eslint and that seems to get it |
Have you tested hover on |
Nevermind. |
…lc from gl3d, parcats and sankey
Thanks @alexhartstone |
Adds a conditional transform recalculation method to plot api, and calls it in interactions