Force default dims for downloadImage to null #5209
Conversation
|
OK we probably need a test here but I think this is the behaviour I want @alexcjohnson :) @antoinerg will this have some impact on the full-json image export format somehow, or does that use |
|
OK so Kaleido uses the underlying The only cases I can think of where this isn't a desireable change is in a Dash app where there is a quite-small chart and people are using the download button to get a bigger version. @chriddyp is this a reason not to do this? This PR essentially fixes plotly/dash-core-components#199 more fully than #3746 did by making it the default. |
|
Also tagging @wbrgss in case there is any limitations that he knows of? |
archmoj
requested review from
chriddyp,
antoinerg,
wbrgss,
jonmmease and
alexcjohnson
|
Seems reasonable 👍 as long as it's overridable for default dimensions (and documented) |
|
OK, great! @archmoj once 1.57 is out, please lock this behaviour down with a test and let's merge it :) |
Do you want it to be in 1.57.0? |
|
No it can wait
On Wed, Oct 14, 2020 at 22:04 Mojtaba Samimi ***@***.***> wrote:
OK, great! @archmoj <https://github.com/archmoj> once 1.57 is out, please
lock this behaviour down with a test and let's merge it :)
Do you want it to be in 1.57.0?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5209 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRWA27UYVIJM44BUYNSU3SKZKBPANCNFSM4SLFHFZQ>
.
--
Nicolas Kruchten-VP Product
Email [email protected]
5555 Gaspe Ave #118, Montreal, QC, H2T 2A3
Plotly is hiring! Check out the listings on our job board here
<https://grnh.se/b0a028082us+?utm_source=WiseStamp&utm_medium=email&utm_term=&utm_content=&utm_campaign=signature>
|
|
The test is added by 5e98788. |
| gd.style.width = '500px'; | ||
| gd.style.height = '300px'; | ||
|
|
||
| Plotly.plot(gd, fig) |
There was a problem hiding this comment.
I assume this test would fail without my change?
There was a problem hiding this comment.
I assume this test would fail without my change?
Yes it used to fail without the changes proposed by you.
Thanks very much @nicolaskruchten for fixing this bug!
|
💃 ! (see my one question above!) |
Another variation on #5205 to address the class of issue of which #5202 is an exemplar ... closes #1576