Upgrade d3 time format to expose new formatting options for weekdays, weeks and quarters #5026
Conversation
- support formatting options e.g. quarters, weeks and weekdays - update description link to list various time format options
|
The fix looks great. But for low-level non-graphical items like this I'd like us to get away from using image tests. This one should just add a few more test cases to this test: plotly.js/test/jasmine/tests/lib_date_test.js Line 551 in 6b6b475 That's both faster (in terms of our overall test suite time going forward) and more complete: we can easily add arbitrarily many cases, and it'll also tell us how the new fields play with world calendars - no need to fix anything that might come up there, I just want to know what we do and do not support, like: plotly.js/test/jasmine/tests/lib_date_test.js Line 575 in 6b6b475 |
This reverts commit 2315777.
…rmatting options namely q, u and W
| @@ -571,15 +571,19 @@ describe('dates', function() { | |||
| ], | |||
| [ | |||
| '%B \'%y WOY:%U DOW:%w', | |||
| 'August \'12 WOY:32 DOW:1', | |||
| 'August \'12 WOY:33 DOW:1', | |||
There was a problem hiding this comment.
Fixed bug reported in d3/d3-time-format#62.
| 'Mon Aug 13 06:19:34 2012 && 08/13/2012 && .57 .5678', | ||
| 'Pes Meso 7 06:19:34 1728 && 12/07/1728 && .57 .5678' | ||
| '8/13/2012, 6:19:34 AM && 8/13/2012 && .57 .5678', | ||
| 'Pes Meso 7 6:19:34 AM 1728 && 12/07/1728 && .57 .5678' |
There was a problem hiding this comment.
According to https://github.com/d3/d3/blob/master/CHANGES.md#time-formats-d3-time-format
The default U.S. English locale now uses 12-hour time and a more concise representation of the date. This aligns with local convention and is consistent with date.toLocaleString in Chrome, Firefox and Node
var now = new Date;
d3.timeFormat("%c")(new Date); // "6/23/2016, 2:01:33 PM"
d3.timeFormat("%x")(new Date); // "6/23/2016"
d3.timeFormat("%X")(new Date); // "2:01:38 PM"
Supersedes #5023 and resolves #5009 by upgrading d3-time-format to the latest version.
@plotly/plotly_js