Dev deps bump PR - first one in 2020 edition #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@archmoj as I'm about to go offline for two weeks, please go ahead and merge this PR if you approve it. |
archmoj
reviewed
Jan 9, 2020
package.json
Outdated
| @@ -98,7 +98,7 @@ | |||
| "mouse-change": "^1.4.0", | |||
| "mouse-event-offset": "^3.0.2", | |||
| "mouse-wheel": "^1.2.0", | |||
| "ndarray": "^1.0.18", | |||
| "ndarray": "^1.0.19", | |||
There was a problem hiding this comment.
This is support for BigInt64Array types and 5 days old.
I prefer opening pull requests for the modules listed below:
ndarray-pack
ndarray-scratch
simplicial-complex-contour
gl-contour2d
gl-cone3d
gl-line3d
gl-mesh3d
gl-scatter3d
gl-plot2d
gl-plot3d
gl-select-static
gl-buffer
gl-texture2d
vectorize-text
There was a problem hiding this comment.
Reverted the ndarray version in d182131 for now.
We could bump that one when the following PRs are merged; and then we could patch gl-vis modules as well.
mikolalysenko/vectorize-text#16
scijs/ndarray-scratch#7
scijs/ndarray-pack#6
mikolalysenko/simplicial-complex-contour#1
There was a problem hiding this comment.
Good call. Thanks @archmoj !
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps two "dependencies":
d3-interpolatefrom v1 to to v1.4.0,d3-hierarchyfrom v1.1.8 to v1.1.9,In addition some dev-dependencies are updated in this PR.
@archmoj we now have
So, our outdated deps are:
d3can't bump until a plotly.js v2d3-forcechanges some sankey baselines, needs investigationes6-promisecan't bump as this breaks plotly.js in IE11 (if I recall correctly)fs-extra, could bump but requires no-trivial changes intasks/image-size, can't bump as newer versions drop support for the Node version used in our image-test docker containerjsdom, could bump but requires no-trivial changes intasks/mapbox-gl, could bump, but I like to bumpmapbox-glin mapbox-related PRsregl, @archmoj what's your take on that one?topojson-client, the newer version appear to not perform as well when I tested it in some past geo work, we could try again.