Correct streamtube positions and colouring #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Oct 11, 2019
package.json
Outdated
| @@ -86,7 +86,7 @@ | |||
| "gl-scatter3d": "^1.2.2", | |||
| "gl-select-box": "^1.0.3", | |||
| "gl-spikes2d": "^1.0.2", | |||
| "gl-streamtube3d": "^1.3.1", | |||
| "gl-streamtube3d": "git://github.com/gl-vis/gl-streamtube3d.git#82a0dd7a8dc601f48ed4afdc5a3e40394b758deb", | |||
There was a problem hiding this comment.
etpinard
reviewed
Oct 11, 2019
|
To clarify, order var x = [];
var y = [];
var z = [];
for(var k = 0; k < Nz; k++) // last changing index
for(var j = 0; j < Ny; j++) // next changing index
for(var i = 0; i < Nx; i++) // first changing index
x.push(i); y.push(j); z.push(k)thanks @archmoj for the tip! |
…ng sampleMeshgrid bugs
archmoj
commented
Oct 15, 2019
etpinard
reviewed
Oct 15, 2019
etpinard
reviewed
Oct 15, 2019
- reduced duplicated code between gl modules - bump gl-cone3d 1.5.0 - bump gl-streamtube3d 1.4.0
…e test for random input
|
Superb fix. Thanks very much @archmoj !! 💃 💃 💃 - oh let's start merging things for 1.51.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4206 and fixes #4275
The
gl-streamtube3dmodule used to make assumptions about the order of input data which could be false in cases where the data cube was not filled in orders thanxyz(i.e firstx| nexty| lastz).This PR addresses this issue by considering the order of data in
calcstep and using this info insidegl-streamtube3dmodule.Before fixing 4206
After fixing 4206
Before fixing 4275
After fixing 4275
In addition
gl-cone3dmodule is patched in this PR.Please refer to the following
gl-visPRs for more details on the changes within dependecies:gl-vis/gl-cone3d#16
gl-vis/gl-cone3d#17
gl-vis/gl-cone3d#18
gl-vis/gl-streamtube3d#10
gl-vis/gl-streamtube3d#11
@plotly/plotly_js