A few mapbox fixes #4197
Merged
A few mapbox fixes #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so the rest of Fx.hover can properly handle it, the bug currently only happens for number locations[i] that make it part of the <extra></extra> hover label content.
... on-par with Plotly.restyle, Plotly.relayout and
Plotly.update
- this can happen when trying to remove a `visible:false` layer
|
These look great! I’ll try the RCE with them to confirm they resolve all the similar-looking mapbox errors I’ve been seeing. |
|
Yup, all of the weird edge cases I was hitting in the RCE go away with these fixes, thanks so much for the quick turnaround :D |
|
💃 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes #4194
before: https://codepen.io/etpinard/pen/pozOKjL?editors=1010 (try hovering)
after: https://codepen.io/etpinard/pen/ZEzMgJy?editors=1010
and the last three combine to fix #4196
before: https://codepen.io/nicolaskruchten/pen/pOVLop (click on all the steps in sequence)
after: https://codepen.io/etpinard/pen/qBWMzoj
These commits will be part of
v1.49.5cc @archmoj @nicolaskruchten