Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable transparency by alpha colors in mesh3d #3744

Merged
merged 4 commits into from
Apr 8, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 8, 2019

Fixes #3741.
Transparent draws enabled in `gl-mesh3d' when using rgba colours.
@etpinard

@archmoj archmoj added bug something broken status: reviewable labels Apr 8, 2019
package.json Outdated
@@ -78,7 +78,7 @@
"gl-heatmap2d": "^1.0.5",
"gl-line3d": "^1.1.11",
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.1.0",
"gl-mesh3d": "git://github.com/gl-vis/gl-mesh3d.git#6651929f5ac2c084ce51a88ff2e40311fab4a46c",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj
Copy link
Contributor Author

archmoj commented Apr 8, 2019

@etpinard
Copy link
Contributor

etpinard commented Apr 8, 2019

Brilliant fix 💃

@archmoj archmoj merged commit ae878a8 into master Apr 8, 2019
@archmoj archmoj deleted the fix3741-enable-opacity-by-alpha branch April 8, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants