Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finance chart null item hover #3537

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

jakubkottnauer
Copy link
Contributor

@jakubkottnauer jakubkottnauer commented Feb 12, 2019

Fixes the bug visible here: https://codepen.io/jakubkottnauer/pen/gqKgeQ

The issue happens when triggering a hover on finance charts via Fx.hover and when the element at the position is null - visually it works correctly but there are errors in console.

@etpinard
Copy link
Contributor

Very solid fix. Thanks very much!

@etpinard
Copy link
Contributor

Related: #3366

@etpinard etpinard added bug something broken status: reviewable labels Feb 12, 2019
@etpinard etpinard merged commit 26d6384 into plotly:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants