Clear _inputDomain on cartesian axes with altered domains #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... during Plotly.react diffing.
etpinard
commented
Jan 22, 2019
| @@ -2954,6 +2954,11 @@ function getDiffFlags(oldContainer, newContainer, outerparts, opts) { | |||
| flags.rangesAltered[outerparts[0]] = 1; | |||
| } | |||
|
|
|||
| // clear _inputDomain on cartesian axes with altered domains | |||
| if(AX_DOMAIN_RE.test(astr)) { | |||
| nestedProperty(newContainer, '_inputDomain').set(null); | |||
There was a problem hiding this comment.
This piece is the react equivalent to this block
plotly.js/src/plot_api/plot_api.js
Lines 2133 to 2135 in 323195e
called during relayout.
|
Looks good to me! Nice fix 👌 |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... during
Plotly.reactdiffing - fixes #3430See now bug-free codepen: https://codepen.io/etpinard/pen/EraKjq
cc @plotly/plotly_js